Skip to content

[Compute] az vmss create/update: Add --skuprofile-rank for prioritized instance mix#31255

Merged
yanzhudd merged 8 commits intoAzure:devfrom
msdorahu:mixsku-prioritized
May 7, 2025
Merged

[Compute] az vmss create/update: Add --skuprofile-rank for prioritized instance mix#31255
yanzhudd merged 8 commits intoAzure:devfrom
msdorahu:mixsku-prioritized

Conversation

@msdorahu
Copy link
Copy Markdown
Contributor

@msdorahu msdorahu commented Apr 11, 2025

Related command
az vmss create/update

Description
This change adds --skuprofile-rank for vmss create and update

Testing Guide
vmss create -n vmssName -g rgName --image ubuntu2204 --vm-sku Mix --skuprofile-vmsizes Standard_DS1_v2 Standard_D2s_v4 --skuprofile-rank "" 1 --skuprofile-allocation-strategy Prioritized

History Notes
[Compute] az vmss create/update: Add new parameter --skuprofile-rank to specify a list of ranks to use with VMSS instance mix SKU profile VM sizes


This checklist is used to make sure that common guidelines for a pull request are followed.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Apr 11, 2025

️✔️AzureCLI-FullTest
️✔️acr
️✔️latest
️✔️3.12
️✔️3.9
️✔️acs
️✔️latest
️✔️3.12
️✔️3.9
️✔️advisor
️✔️latest
️✔️3.12
️✔️3.9
️✔️ams
️✔️latest
️✔️3.12
️✔️3.9
️✔️apim
️✔️latest
️✔️3.12
️✔️3.9
️✔️appconfig
️✔️latest
️✔️3.12
️✔️3.9
️✔️appservice
️✔️latest
️✔️3.12
️✔️3.9
️✔️aro
️✔️latest
️✔️3.12
️✔️3.9
️✔️backup
️✔️latest
️✔️3.12
️✔️3.9
️✔️batch
️✔️latest
️✔️3.12
️✔️3.9
️✔️batchai
️✔️latest
️✔️3.12
️✔️3.9
️✔️billing
️✔️latest
️✔️3.12
️✔️3.9
️✔️botservice
️✔️latest
️✔️3.12
️✔️3.9
️✔️cdn
️✔️latest
️✔️3.12
️✔️3.9
️✔️cloud
️✔️latest
️✔️3.12
️✔️3.9
️✔️cognitiveservices
️✔️latest
️✔️3.12
️✔️3.9
️✔️compute_recommender
️✔️latest
️✔️3.12
️✔️3.9
️✔️computefleet
️✔️latest
️✔️3.12
️✔️3.9
️✔️config
️✔️latest
️✔️3.12
️✔️3.9
️✔️configure
️✔️latest
️✔️3.12
️✔️3.9
️✔️consumption
️✔️latest
️✔️3.12
️✔️3.9
️✔️container
️✔️latest
️✔️3.12
️✔️3.9
️✔️containerapp
️✔️latest
️✔️3.12
️✔️3.9
️✔️core
️✔️latest
️✔️3.12
️✔️3.9
️✔️cosmosdb
️✔️latest
️✔️3.12
️✔️3.9
️✔️databoxedge
️✔️latest
️✔️3.12
️✔️3.9
️✔️dls
️✔️latest
️✔️3.12
️✔️3.9
️✔️dms
️✔️latest
️✔️3.12
️✔️3.9
️✔️eventgrid
️✔️latest
️✔️3.12
️✔️3.9
️✔️eventhubs
️✔️latest
️✔️3.12
️✔️3.9
️✔️feedback
️✔️latest
️✔️3.12
️✔️3.9
️✔️find
️✔️latest
️✔️3.12
️✔️3.9
️✔️hdinsight
️✔️latest
️✔️3.12
️✔️3.9
️✔️identity
️✔️latest
️✔️3.12
️✔️3.9
️✔️iot
️✔️latest
️✔️3.12
️✔️3.9
️✔️keyvault
️✔️latest
️✔️3.12
️✔️3.9
️✔️lab
️✔️latest
️✔️3.12
️✔️3.9
️✔️managedservices
️✔️latest
️✔️3.12
️✔️3.9
️✔️maps
️✔️latest
️✔️3.12
️✔️3.9
️✔️marketplaceordering
️✔️latest
️✔️3.12
️✔️3.9
️✔️monitor
️✔️latest
️✔️3.12
️✔️3.9
️✔️mysql
️✔️latest
️✔️3.12
️✔️3.9
️✔️netappfiles
️✔️latest
️✔️3.12
️✔️3.9
️✔️network
️✔️latest
️✔️3.12
️✔️3.9
️✔️policyinsights
️✔️latest
️✔️3.12
️✔️3.9
️✔️privatedns
️✔️latest
️✔️3.12
️✔️3.9
️✔️profile
️✔️latest
️✔️3.12
️✔️3.9
️✔️rdbms
️✔️latest
️✔️3.12
️✔️3.9
️✔️redis
️✔️latest
️✔️3.12
️✔️3.9
️✔️relay
️✔️latest
️✔️3.12
️✔️3.9
️✔️resource
️✔️latest
️✔️3.12
️✔️3.9
️✔️role
️✔️latest
️✔️3.12
️✔️3.9
️✔️search
️✔️latest
️✔️3.12
️✔️3.9
️✔️security
️✔️latest
️✔️3.12
️✔️3.9
️✔️servicebus
️✔️latest
️✔️3.12
️✔️3.9
️✔️serviceconnector
️✔️latest
️✔️3.12
️✔️3.9
️✔️servicefabric
️✔️latest
️✔️3.12
️✔️3.9
️✔️signalr
️✔️latest
️✔️3.12
️✔️3.9
️✔️sql
️✔️latest
️✔️3.12
️✔️3.9
️✔️sqlvm
️✔️latest
️✔️3.12
️✔️3.9
️✔️storage
️✔️latest
️✔️3.12
️✔️3.9
️✔️synapse
️✔️latest
️✔️3.12
️✔️3.9
️✔️telemetry
️✔️latest
️✔️3.12
️✔️3.9
️✔️util
️✔️latest
️✔️3.12
️✔️3.9
️✔️vm
️✔️latest
️✔️3.12
️✔️3.9

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd bot commented Apr 11, 2025

⚠️AzureCLI-BreakingChangeTest
⚠️vm
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd vmss create cmd vmss create added parameter skuprofile_rank
⚠️ 1010 - ParaPropUpdate vmss create cmd vmss create update parameter skuprofile_allostrat: updated property choices from ['CapacityOptimized', 'LowestPrice'] to ['CapacityOptimized', 'LowestPrice', 'Prioritized']
⚠️ 1006 - ParaAdd vmss update cmd vmss update added parameter skuprofile_rank
⚠️ 1010 - ParaPropUpdate vmss update cmd vmss update update parameter skuprofile_allostrat: updated property choices from ['CapacityOptimized', 'LowestPrice'] to ['CapacityOptimized', 'LowestPrice', 'Prioritized']

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Apr 11, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link
Copy Markdown

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Apr 11, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot added the Compute az vm/vmss/image/disk/snapshot label Apr 11, 2025
@msdorahu msdorahu changed the title [Compute] az vmss create/update: Add --skuprofile-rank for Prioritized Instance Mix [Compute] az vmss create/update: Add --skuprofile-rank for Prioritized Instance Mix Apr 11, 2025
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Apr 12, 2025

Please fix CI issues

@msdorahu
Copy link
Copy Markdown
Contributor Author

@yonzhan all checks have passed, please review the PR, thanks

@yanzhudd
Copy link
Copy Markdown
Contributor

please resolve the code conflicts

@yanzhudd
Copy link
Copy Markdown
Contributor

please note that Azure CLI will have a code freeze on 04/21/2025 07:00 UTC for the upcoming release. Please address the comments ASAP, otherwise it has to be postponed to next sprint (05-19).

@msdorahu
Copy link
Copy Markdown
Contributor Author

@yanzhudd conflicts have been resolved

Comment thread src/azure-cli/azure/cli/command_modules/vm/_params.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/vm/_params.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/vm/_template_builder.py
@msdorahu msdorahu force-pushed the mixsku-prioritized branch from be31d98 to fd16e99 Compare April 30, 2025 18:31
@yanzhudd yanzhudd changed the title [Compute] az vmss create/update: Add --skuprofile-rank for Prioritized Instance Mix [Compute] az vmss create/update: Add --skuprofile-rank for prioritized instance mix May 7, 2025
@yanzhudd
Copy link
Copy Markdown
Contributor

yanzhudd commented May 7, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@yanzhudd
Copy link
Copy Markdown
Contributor

yanzhudd commented May 7, 2025

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 3 pipeline(s).

@yanzhudd yanzhudd merged commit f0643c2 into Azure:dev May 7, 2025
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Compute az vm/vmss/image/disk/snapshot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants